Human-in-the-Loop Implementation #2021

mjschock · 2025-11-01T01:47:43Z

Resolves #636.

OPENAI_API_KEY="your_api_key_here" uv run python examples/agent_patterns/human_in_the_loop.py

================================================================================
Run interrupted - tool approval required
================================================================================
State saved to result.json
Loading state from result.json

Tool call details:
  Agent: Weather Assistant
  Tool: get_temperature
  Arguments: {"city":"Oakland"}

Do you approve this tool call? (y/n): y
✓ Approved: get_temperature

Resuming agent execution...

================================================================================
Final Output:
================================================================================
The weather in Oakland is sunny, and the temperature is 20°C.

OPENAI_API_KEY="your_api_key_here" uv run python examples/agent_patterns/human_in_the_loop_stream.py 

================================================================================
Human-in-the-loop: approval required for the following tool calls:
================================================================================

Tool call details:
  Agent: Weather Assistant
  Tool: get_temperature
  Arguments: {"city":"Oakland"}

Do you approve this tool call? (y/n): y
✓ Approved: get_temperature

Resuming agent execution...

================================================================================
Final Output:
================================================================================
The current weather in Oakland is sunny, with a temperature of 20°C.

Done!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-11-01T18:19:41Z

src/agents/run.py

        previous_response_id: str | None,
        conversation_id: str | None,
        session: Session | None,
+        run_state: RunState[TContext] | None = None,
    ):
        if streamed_result.trace:
            streamed_result.trace.start(mark_as_current=True)


Prime server tracker when resuming streaming runs

When Runner.run_streamed resumes from a RunState with conversation_id or previous_response_id, _start_streaming constructs a _ServerConversationTracker but never seeds it with the prior model_responses that were already sent. Unlike the synchronous path, no call to track_server_items is made, so prepare_input treats every previously generated item as unsent and resubmits them to the server. This duplicates earlier messages and breaks server-side conversation threading when a run is resumed.

Useful? React with 👍 / 👎.

Fixed in a56ce0a. Added server conversation tracker priming at lines 1076-1079 to match the non-streaming implementation and prevent message duplication when resuming from RunState.

chatgpt-codex-connector · 2025-11-01T18:19:41Z

src/agents/run.py

        previous_response_id: str | None,
        conversation_id: str | None,
        session: Session | None,
+        run_state: RunState[TContext] | None = None,
    ):
        if streamed_result.trace:
            streamed_result.trace.start(mark_as_current=True)


Streaming resume ignores existing turn count

The streaming execution path always initializes current_turn = 0 when _start_streaming is called, even if a RunState with an existing _current_turn is supplied. The loop then increments from zero, so any turns completed before the interruption are ignored and the max_turns guard is reset. After each interruption, a resumed streaming run can exceed the user’s turn limit and misreport the current turn number.

Useful? React with 👍 / 👎.

This was already fixed in 74c50fd at line 914: current_turn=run_state._current_turn if run_state else 0. The turn counter is properly restored from the RunState.

…essage duplication When resuming a streaming run from RunState, the server conversation tracker was not being primed with previously sent model responses. This caused `prepare_input` to treat all previously generated items as unsent and resubmit them to the server, breaking conversation threading. **Issue**: Missing `track_server_items` call in streaming resumption path **Fix**: Added server conversation tracker priming logic in `_start_streaming` method (lines 1076-1079) to match the non-streaming path implementation (lines 553-556). The fix iterates through `run_state._model_responses` and calls `track_server_items(response)` to mark them as already sent to the server. **Impact**: Resolves message duplication when resuming interrupted streaming runs, ensuring proper conversation threading with server-side sessions. Fixes code review feedback from PR openai#2021 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

seratch · 2025-11-04T02:33:20Z

Thanks for sending this patch!

I currently don't have the bandwidth to check this in depth, but one thing I wanted to mention is that, while implementing the sessions feature in openai-agents-js project, I found that the internals of runner need to take various HITL patterns into consideration. There might not be necessary to make those changes in this Python SDK, but sufficient testing for the sessions scenarios is worth doing.

mjschock · 2025-11-04T17:45:50Z

Thanks for sending this patch!

I currently don't have the bandwidth to check this in depth, but one thing I wanted to mention is that, while implementing the sessions feature in openai-agents-js project, I found that the internals of runner need to take various HITL patterns into consideration. There might not be necessary to make those changes in this Python SDK, but sufficient testing for the sessions scenarios is worth doing.

Happy to contribute! I added a couple examples using SQLiteSession and OpenAIConversationsSession and made sure they work:

OPENAI_API_KEY="your_api_key_here" uv run python examples/memory/memory_session_hitl_example.py 
=== Memory Session + HITL Example ===
Session id: :memory:
Enter a message to chat with the agent. Submit an empty line to exit.
The agent will ask for approval before using tools.

You: What cities does the Bay Bridge connect?
Assistant: The Bay Bridge connects San Francisco and Oakland in California.

You: What's the weather in those cities?

Agent HITL Assistant wants to call 'get_weather' with {"location":"San Francisco, CA"}. Approve? (y/n): y
Approved tool call.

Agent HITL Assistant wants to call 'get_weather' with {"location":"Oakland, CA"}. Approve? (y/n): y
Approved tool call.
Assistant: San Francisco is currently foggy with a temperature of 58°F. Oakland is sunny with a temperature of 72°F.

You:

OPENAI_API_KEY="your_api_key_here" uv run python examples/memory/openai_session_hitl_example.py 
=== OpenAI Session + HITL Example ===
Enter a message to chat with the agent. Submit an empty line to exit.
The agent will ask for approval before using tools.

You: What cities does the Bay Bridge connect?
Assistant: The Bay Bridge, officially known as the San Francisco–Oakland Bay Bridge, connects the cities of **San Francisco** and **Oakland** in California.

You: What's the weather in those cities?

Agent HITL Assistant wants to call 'get_weather' with {"location":"San Francisco, CA"}. Approve? (y/n): y
Approved tool call.

Agent HITL Assistant wants to call 'get_weather' with {"location":"Oakland, CA"}. Approve? (y/n): y
Approved tool call.
Assistant: San Francisco is currently foggy and 58°F, while Oakland is sunny and 72°F.

You:

I'm hoping that just about covers everything but lemme know if there are other areas I should make sure address.

…essage duplication When resuming a streaming run from RunState, the server conversation tracker was not being primed with previously sent model responses. This caused `prepare_input` to treat all previously generated items as unsent and resubmit them to the server, breaking conversation threading. **Issue**: Missing `track_server_items` call in streaming resumption path **Fix**: Added server conversation tracker priming logic in `_start_streaming` method (lines 1076-1079) to match the non-streaming path implementation (lines 553-556). The fix iterates through `run_state._model_responses` and calls `track_server_items(response)` to mark them as already sent to the server. **Impact**: Resolves message duplication when resuming interrupted streaming runs, ensuring proper conversation threading with server-side sessions. Fixes code review feedback from PR openai#2021 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

mjschock · 2025-11-06T18:48:09Z

Thanks @seratch for adding it to the 0.6.x milestone! I'll make sure to address any feedback.

mjschock · 2025-11-08T19:52:35Z

Just a heads up. I noticed there are some discrepancies with the serialized RunState when interrupting in Python and resuming in TypeScript and visa versa. I'm addressing those this weekend and will push the update.

…essage duplication When resuming a streaming run from RunState, the server conversation tracker was not being primed with previously sent model responses. This caused `prepare_input` to treat all previously generated items as unsent and resubmit them to the server, breaking conversation threading. **Issue**: Missing `track_server_items` call in streaming resumption path **Fix**: Added server conversation tracker priming logic in `_start_streaming` method (lines 1076-1079) to match the non-streaming path implementation (lines 553-556). The fix iterates through `run_state._model_responses` and calls `track_server_items(response)` to mark them as already sent to the server. **Impact**: Resolves message duplication when resuming interrupted streaming runs, ensuring proper conversation threading with server-side sessions. Fixes code review feedback from PR openai#2021 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

seratch · 2025-11-16T03:27:40Z

@codex Can you do reviews on the code changes in this PR with fresh eyes? Please focus on the potential issues for existing apps and edge case scenarios rather than general feedback.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-11-16T03:31:21Z

src/agents/run.py


            await AgentRunner._save_result_to_session(session, starting_input, [])


Avoid duplicating session history when resuming streaming runs

When Runner.run_streamed is resumed from a RunState, _start_streaming still calls _prepare_input_with_session and _save_result_to_session unconditionally (streamed_result.input is recomputed and the original prompt is saved again). In the non‑streaming path these calls are skipped when a RunState is supplied so that the session history isn’t duplicated. Re‑preparing and saving here means a resumed streaming run writes the same user message back into the session and the next turn will see duplicate user prompts, breaking conversations for apps that rely on Session or session_input_callback. Consider gating these calls with run_state is None as the synchronous path does.

Useful? React with 👍 / 👎.

👍 Fixed in 466c306

…essage duplication When resuming a streaming run from RunState, the server conversation tracker was not being primed with previously sent model responses. This caused `prepare_input` to treat all previously generated items as unsent and resubmit them to the server, breaking conversation threading. **Issue**: Missing `track_server_items` call in streaming resumption path **Fix**: Added server conversation tracker priming logic in `_start_streaming` method (lines 1076-1079) to match the non-streaming path implementation (lines 553-556). The fix iterates through `run_state._model_responses` and calls `track_server_items(response)` to mark them as already sent to the server. **Impact**: Resolves message duplication when resuming interrupted streaming runs, ensuring proper conversation threading with server-side sessions. Fixes code review feedback from PR openai#2021 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

… coverage

…codex-connector

…gent usage and saving tool outputs to session

…fresh_run_exercises_persistence

…debug

…tchAction

…Result to RunState

…reserved during state conversion

…rsisted item count during streamed run resumption

… AgentRunner

…ization

…ll types in RunState

…n HITL coverage

mjschock · 2025-12-12T20:00:29Z

@codex review

chatgpt-codex-connector · 2025-12-12T20:06:28Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mjschock mentioned this pull request Nov 1, 2025

Human-In-The-Loop Architecture should be implemented on top priority! #636

Open

mjschock marked this pull request as ready for review November 1, 2025 18:16

chatgpt-codex-connector bot reviewed Nov 1, 2025

View reviewed changes

seratch added enhancement New feature or request feature:core labels Nov 4, 2025

mjschock force-pushed the main branch from b262f66 to 3d52667 Compare November 4, 2025 17:47

mjschock force-pushed the main branch from 3d52667 to f30310e Compare November 4, 2025 17:55

mjschock force-pushed the main branch from f30310e to 110dcbd Compare November 5, 2025 02:15

seratch added this to the 0.6.x milestone Nov 5, 2025

mjschock force-pushed the main branch from 110dcbd to b38b2f7 Compare November 6, 2025 18:45

mjschock force-pushed the main branch from 2bc0ce0 to 9f37210 Compare November 14, 2025 02:12

mjschock force-pushed the main branch from 9f37210 to 1947718 Compare November 14, 2025 16:54

mjschock force-pushed the main branch from 1947718 to def65ac Compare November 16, 2025 01:42

chatgpt-codex-connector bot reviewed Nov 16, 2025

View reviewed changes

mjschock force-pushed the main branch from 66df149 to 9ca00a8 Compare November 17, 2025 23:43

seratch removed this from the 0.6.x milestone Nov 18, 2025

mjschock added 27 commits December 12, 2025 11:30

test: add tests for RunState resumption and serialization to bring up…

158b207

… coverage

fix: Updates following rebase, include test coverage

8d86d5f

fix: address issues around resuming run state with conversation history

b8bcfee

fix: address duplicating session history issue mentioned by @chatgpt-…

76a9284

…codex-connector

fix: update RunState with current turn persisted item tracking

d74f65d

fix: addressing edge cases when resuming

c6eb09f

fix: addressing edge cases when resuming (continued)

5ba9771

fix: addressing rebase issues

7aafed8

fix: improving parity with openai-agent-js hitl functionality

6da3770

fix: bring coverage back up, addressing edge cases

f38a255

fix: cleanup

0d863fb

fix: rename summary_message back to assistant_message

9c9e3ae

fix: enhance agent state management during resume, ensuring correct a…

8f29752

…gent usage and saving tool outputs to session

fix: finish up human-in-the-loop port

ac6e40e

fix: add auto_previous_response_id parameter to test_start_streaming_…

350afff

…fresh_run_exercises_persistence

fix: typing updates to pass make old_version_tests

105150c

fix: remove dead code and add failing hitl error scenarios

964df47

fix: address failing hitl error scenarios

ff18b91

fix: change logging level for _ServerConversationTracker creation to …

5953b6f

…debug

fix: pass context_wrapper to _coerce_apply_patch_operation in ApplyPa…

a69b34e

…tchAction

fix: add test to ensure current turn is preserved when converting Run…

fd10f5f

…Result to RunState

fix: update RunResult to track current turn number and ensure it is p…

b7158a0

…reserved during state conversion

fix: add tests to ensure ToolApprovalItem hashability and preserve pe…

52f92f6

…rsisted item count during streamed run resumption

refactor: simplify condition for current turn persisted item count in…

d6c2623

… AgentRunner

test: add tests to preserve tool output types during run state serial…

c2d2fce

…ization

fix: enhance output item conversion logic to preserve non-function ca…

ecb6c11

…ll types in RunState

fix: update test to use ResponseCustomToolCall for apply_patch call i…

229b086

…n HITL coverage

mjschock force-pushed the main branch from 16afcce to 229b086 Compare December 12, 2025 19:51


		await AgentRunner._save_result_to_session(session, starting_input, [])

Human-in-the-Loop Implementation #2021

Are you sure you want to change the base?

Human-in-the-Loop Implementation #2021

Conversation

mjschock commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

mjschock Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

mjschock Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

seratch commented Nov 4, 2025

Uh oh!

mjschock commented Nov 4, 2025

Uh oh!

mjschock commented Nov 6, 2025

Uh oh!

mjschock commented Nov 8, 2025

Uh oh!

seratch commented Nov 16, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Nov 16, 2025

Choose a reason for hiding this comment

Uh oh!

mjschock Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

mjschock commented Dec 12, 2025

Uh oh!

chatgpt-codex-connector bot commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mjschock commented Nov 1, 2025 •

edited

Loading